Skip to content

Add xfail test for df.astype(pa.DictionaryType)#2188

Open
NickCrews wants to merge 1 commit intovaexio:masterfrom
NickCrews:dictionary_casting
Open

Add xfail test for df.astype(pa.DictionaryType)#2188
NickCrews wants to merge 1 commit intovaexio:masterfrom
NickCrews:dictionary_casting

Conversation

@NickCrews
Copy link
Contributor

Demonstration of
#2187

@NickCrews NickCrews changed the title Dictionary_casting Add xfail test for df.astype(pa.DictionaryType) Aug 29, 2022
@maartenbreddels
Copy link
Member

So, it works for some cases, because our dtype wrapper compared true to str when it's an encoded type that maps to str.
Next problem is, that because of the expression system, we would need to add the types passed in to the variables, because a repr(arrow_dtype) cannot be evaluated again.
This would need to use a similar ideas as #2089 where we don't add types multiple times.

For the rest, I'll first wait for your response to #2187 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants