Compute qName once we've filled in the local array. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it depends on it. Fixes validator#91
Contributor
Author
|
@sideshowbarker can you confirm this fixes the issue you're seeing? |
Contributor
Author
|
Build failures seem unrelated |
Contributor
Author
|
cc @hsivonen |
Member
Yeah, it does (and thanks much) |
sideshowbarker
approved these changes
Oct 18, 2024
Member
sideshowbarker
left a comment
sideshowbarker
left a comment
There was a problem hiding this comment.
Will wait to merge until @hsivonen has also reviewed
hsivonen
approved these changes
Oct 30, 2024
Member
hsivonen
left a comment
hsivonen
left a comment
There was a problem hiding this comment.
Thanks! How has this ever worked at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it depends on it.
Fixes #91