Skip to content

Fix incorrect solution file reference in .vscode/settings.json #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect solution file reference in .vscode/settings.json #122

wants to merge 1 commit into from

Conversation

@jbrinkman
Copy link
Collaborator

Description

This PR fixes the incorrect solution file reference in .vscode/settings.json that was causing C# language server failures.

Changes

  • Updated dotnet.defaultSolution from "csharp.sln" (non-existent) to "Valkey.Glide.sln" (correct)

Impact

This fix resolves several developer experience issues:

  • ✅ C# IntelliSense features (Go to Definition, Find All References) now work correctly
  • ✅ Language server loads the solution successfully without errors
  • ✅ Project dependencies are properly resolved
  • ✅ No more InvalidOperationException in language server logs

Testing

  • Verified the solution file Valkey.Glide.sln exists in the repository
  • Tested that C# language server loads successfully after the change
  • Confirmed IntelliSense features work as expected
  • No errors in language server output logs

Related Issues

Fixes #121

Checklist

  • Code follows project style guidelines
  • Change has been tested locally
  • Commit message follows conventional commit format
  • Commit includes DCO signoff

@jbrinkman
fix: correct solution file reference in .vscode/settings.json
5750971 
Update dotnet.defaultSolution from non-existent 'csharp.sln' to correct 'Valkey.Glide.sln'.
This fixes C# language server failures that prevented IntelliSense features like
Go to Definition and Find All References from working.

Fixes #121

Signed-off-by: Joe Brinkman <[email protected]>
@jbrinkman jbrinkman requested a review from a team as a code owner October 28, 2025 15:04
currantw
currantw approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@currantw currantw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this @jbrinkman ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@currantw currantw currantw approved these changes

@alexr-bq alexr-bq Awaiting requested review from alexr-bq

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix incorrect solution file reference in .vscode/settings.json

4 participants

@jbrinkman @yipin-chen @currantw