Command array arguments that render with a token for each element

[adam-fowler]

• Add RESPArrayWithToken that renders each element with token prefix
• Use RESPArrayWithToken for elements with flag multiple_token
• Use CLIENT TRACKING to test this

[github-actions]

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '0dffa70ef662' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	76	76	78	80	80	80	80	6
pull_request	76	79	79	82	84	84	84	6
Δ	0	3	1	2	4	4	4	0
Improvement %	0	-4	-1	-2	-5	-5	-5	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	75	77	79	82	84	84	84	28
pull_request	72	78	80	83	84	88	88	28
Δ	-3	1	1	1	0	4	4	0
Improvement %	4	-1	-1	-1	0	-5	-5	0

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	4	4	8
pull_request	4	4	4	4	4	4	4	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	7	8	8	10	11	11	11	8
pull_request	7	8	8	10	11	11	11	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	34	34	34	34	34	6
pull_request	33	33	34	34	34	34	34	6
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	33	34	34	34	34	6
pull_request	33	33	33	34	34	34	34	6
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	17
pull_request	0	0	0	0	0	0	0	18
Δ	0	0	0	0	0	0	0	1
Improvement %	0	0	0	0	0	0	0	1

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	737
pull_request	0	0	0	0	0	0	0	733
Δ	0	0	0	0	0	0	0	-4
Improvement %	0	0	0	0	0	0	0	-4

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	1831
pull_request	0	0	0	0	0	0	0	1885
Δ	0	0	0	0	0	0	0	54
Improvement %	0	0	0	0	0	0	0	54

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	356
pull_request	0	0	0	0	0	0	0	358
Δ	0	0	0	0	0	0	0	2
Improvement %	0	0	0	0	0	0	0	2

[philippzagar]

Looks good from my perspective!

[nilanshu-sharma]

Good catch, I missed this in my previous PR.

[philippzagar]

@adam-fowler Will this fix be released as a 0.4.1 patch or are you waiting for 0.5.0?

[adam-fowler]

@adam-fowler Will this fix be released as a 0.4.1 patch or are you waiting for 0.5.0?

I can look to do a v0.4.1

[adam-fowler]

@adam-fowler Will this fix be released as a 0.4.1 patch or are you waiting for 0.5.0?

I had a look what we have there are quite a few changes on main already (It would be a v0.5.0, if it was a release). We also have a number of breaking changes just about to be merged in the next week I'd rather wait for those to come through before doing a release