Add ValkeyClusterDiscovery #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2025-04-18T13:55:08+00:00 |
adam-fowler
reviewed
Apr 15, 2025
| /// A description of a single node that is part of a valkey cluster | ||
| public protocol ValkeyNodeDescriptionProtocol: Sendable, Equatable { | ||
| /// The node's host name. | ||
| var host: String? { get } |
Collaborator
There was a problem hiding this comment.
It would be good if we were consistent across the package in how we describe a server address. Could we use ServerAddress here?
Collaborator
Author
There was a problem hiding this comment.
Most discovery mechanisms that I have seen work exactly this way (3 out of 3). I think it should be our job to map this back into ServerAddress and not the users.
adam-fowler
approved these changes
Apr 23, 2025
adam-fowler
added a commit
that referenced
this pull request
Jul 11, 2025
Co-authored-by: Adam Fowler <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 14, 2025
Co-authored-by: Adam Fowler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.