Code generation fixes and custom return values #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commands that only return simple OK return Void - Commands that return a Set, return an [RESPToken] - Remove Response typealias when it is RESPToken so it can be overridden
|
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2025-04-18T10:54:50+00:00 |
fabianfett
approved these changes
Apr 24, 2025
Collaborator
fabianfett
left a comment
fabianfett
left a comment
There was a problem hiding this comment.
Please fix description though.
adam-fowler
added a commit
that referenced
this pull request
Jul 11, 2025
* Code generation cleanup and fixes - Commands that only return simple OK return Void - Commands that return a Set, return an [RESPToken] - Remove Response typealias when it is RESPToken so it can be overridden * Add custom return values for string and list commands * Return RESPToken.Array, RESPToken.Map
adam-fowler
added a commit
that referenced
this pull request
Jul 14, 2025
* Code generation cleanup and fixes - Commands that only return simple OK return Void - Commands that return a Set, return an [RESPToken] - Remove Response typealias when it is RESPToken so it can be overridden * Add custom return values for string and list commands * Return RESPToken.Array, RESPToken.Map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a number of minor fixes to code generation plus has added the ability to setup our own custom return values for commands.
Setnow return anRESPToken.Arrayinstead of aRESPToken.RESPToken.Array. If you want anArrayyou can use theconverting(to:)function.RESPToken.Map. If you want aDictionaryyou can use theconverting(to:)function.OKreturnVoid.RESPToken. This allows us to override these in code.Responseoverrides for the string and list commands LCS, LPOP, LPOS, RPOP.