Skip to content

fix(vite-plugin): Omit React-Router v7 plugin for DevServer #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askoufis merged 4 commits into from
Oct 24, 2024
Merged

fix(vite-plugin): Omit React-Router v7 plugin for DevServer #1492

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b76e8e0
fix(VitePlugin): Omit React-Router plugin for DevServer
kube Oct 20, 2024
67dd522
Add changeset
kube Oct 20, 2024
a956609
Update .changeset/vite-plugin-react-router.md
askoufis Oct 23, 2024
ff1e357
Format
kube Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/vite-plugin-react-router.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@vanilla-extract/vite-plugin': patch
---

Don't pass React-Router Vite plugin to the vite-node compiler


React-Router throws an error if it's loaded without a config file, which is what we do when we initialise the vite-node compiler.
5 changes: 4 additions & 1 deletion packages/vite-plugin/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ const removeIncompatiblePlugins = (plugin: PluginOption) =>
// Additionally, some internal Remix plugins rely on a `ctx` object to be initialized by
// the main Remix plugin, and may not function correctly without it. To address this, we
// filter out all Remix-related plugins.
!plugin.name.startsWith('remix');
!plugin.name.startsWith('remix') &&
// As React-Router plugin works the same as Remix plugin, also ignore it.
!plugin.name.startsWith('react-router');


interface Options {
identifiers?: IdentifierOption;
Expand Down