Refactor encoder property to weak reference in KeyedContainerImpl and UnkeyedContainerImpl to prevent retain cycles#239
Merged
gwynne merged 4 commits intovapor:mainfrom Jul 31, 2025
makoni:main
Merged
Refactor encoder property to weak reference in KeyedContainerImpl and UnkeyedContainerImpl to prevent retain cycles#239gwynne merged 4 commits intovapor:mainfrom makoni:main
gwynne merged 4 commits intovapor:mainfrom
makoni:main
Conversation
… UnkeyedContainerImpl to prevent retain cycles
gwynne
requested changes
Jul 31, 2025
…Impl and UnkeyedContainerImpl to prevent retain cycles" This reverts commit 9a79408.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 68.44% 76.33% +7.89%
==========================================
Files 5 5
Lines 263 262 -1
==========================================
+ Hits 180 200 +20
+ Misses 83 62 -21
🚀 New features to boost your workflow:
|
gwynne
requested changes
Jul 31, 2025
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.5.1
I've noticed memory usage growth in my project that is described in #238
After adding some tests and running
leaks, I found that currently there are retain cycles. That PR fixes them.That's what
leaksprinted (a lot of similar messages):