Skip to content

Conversation

mitchelladam
Copy link

currently vavr-gson only supports Maps with java.lang.String keys, this update allows for completely arbitrary key types including complex or nested keys.

@codecov-io
Copy link

Codecov Report

Merging #8 (9a8da5b) into master (af6c02c) will decrease coverage by 2.04%.
The diff coverage is 91.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #8      +/-   ##
=============================================
- Coverage     100.00%   97.95%   -2.05%     
- Complexity       101      107       +6     
=============================================
  Files              9        9              
  Lines            209      245      +36     
  Branches           8       12       +4     
=============================================
+ Hits             209      240      +31     
- Misses             0        3       +3     
- Partials           0        2       +2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/vavr/gson/MultimapConverter.java 88.88% <0.00%> (-11.12%) 6.00 <0.00> (ø)
...c/main/java/io/vavr/gson/TraversableConverter.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
src/main/java/io/vavr/gson/MapTypeConverter.java 84.61% <84.61%> (ø) 10.00 <10.00> (?)
src/main/java/io/vavr/gson/ArrayTypeConverter.java 100.00% <100.00%> (ø) 7.00 <1.00> (?)
src/main/java/io/vavr/gson/MapConverter.java 100.00% <100.00%> (ø) 8.00 <5.00> (+2.00)
src/main/java/io/vavr/gson/OptionConverter.java 100.00% <100.00%> (ø) 9.00 <1.00> (ø)
src/main/java/io/vavr/gson/TupleConverter.java 100.00% <100.00%> (ø) 7.00 <1.00> (ø)
src/main/java/io/vavr/gson/VavrGson.java 100.00% <100.00%> (ø) 50.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6c02c...9a8da5b. Read the comment docs.

@mitchelladam
Copy link
Author

any chance this might get merged soon?

@mitchelladam
Copy link
Author

over 4 years now, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants