Integrate parameter validation for Azure Key Vault client auth#375
Open
AsmCord wants to merge 10 commits intovcsjones:mainfrom
Open
Integrate parameter validation for Azure Key Vault client auth#375AsmCord wants to merge 10 commits intovcsjones:mainfrom
AsmCord wants to merge 10 commits intovcsjones:mainfrom
Conversation
Removed TODO comment regarding certificate thumbprint authentication support.
vcsjones
reviewed
Mar 2, 2026
Co-authored-by: Kevin Jones <vcsjones@github.com>
… into main_adapted
Added validation to ensure --azure-key-vault-client-auth-certificate is a valid 40-character hexadecimal string when used with --azure-key-vault-client-id. Introduced IsValidHex method to perform this check and display an error if validation fails.
Author
|
What can i do to help finish the pull request. I am a github rookie, let me know if i missed something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New options allows more control which computer can sign and use the codesigning certificate, because it does not depend on the knowledge of the secret in the build pipeline
Integrate the ability to use a dedicated certificate to secure and validate the communication between the caller of the AzureSignTool (typically a build machine) and the Key Vault which might be located elsewhere.
Add new parameter options to control the behavior.