Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
paologalligit
force-pushed
the
paolo/evm-5656
branch
from
5745542 to
b5127d9
Compare
paologalligit
force-pushed
the
paolo/evm-5656
branch
from
b5127d9 to
f6913eb
Compare
otherview
reviewed
Mar 5, 2026
Member
otherview
left a comment
otherview
left a comment
There was a problem hiding this comment.
We probably want to add tests for this opcode in TestPreForkOpCode and hook the ForkConfig, what do you think ?
| if len == 0 { | ||
| return | ||
| } | ||
| if src+len > uint64(m.Len()) || dst+len > uint64(m.Len()) { |
Member
There was a problem hiding this comment.
Is it possible src+len overflows and becomes true ( when is actually false ) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduce the
MCOPYopcode as described in EIP-5656.Issue
Checklist: