Replace inline bitmasks with defines in COMM_GET_VALUES_SELECTIVE and COMM_GET_VALUES_SETUP_SELECTIVE#845
Open
imbus64 wants to merge 2 commits intovedderb:masterfrom
Open
Replace inline bitmasks with defines in COMM_GET_VALUES_SELECTIVE and COMM_GET_VALUES_SETUP_SELECTIVE#845imbus64 wants to merge 2 commits intovedderb:masterfrom
imbus64 wants to merge 2 commits intovedderb:masterfrom
Conversation
added 2 commits
July 30, 2025 07:34
…tmasks instead of magic numbers
…fines as bitmask values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested so far. Not sure if datatypes.h is a suitable place for defines.