feat!: upgrade to deno v2 #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lowlighter is attempting to deploy a commit to the Vercel Deno Team on Vercel. A member of the Team first needs to authorize it. |
lowlighter
commented
May 30, 2025
| "globals": { | ||
| "ts-jest": { | ||
| "diagnostics": false, | ||
| "isolatedModules": true |
There was a problem hiding this comment.
(jest says that they now read it from the tsconfig.json)
| "overrides": { | ||
| "minimatch": "5.1.2", | ||
| "glob": "8.1.0" | ||
| } |
There was a problem hiding this comment.
| ) { | ||
| args['--allow-net'] ??= [] | ||
| args['--allow-net'].push(env.AWS_LAMBDA_RUNTIME_API) | ||
| } |
| '-c': '--config', | ||
| '--import-map': String, | ||
| '--lock': String, | ||
| '--unstable': Boolean, |
There was a problem hiding this comment.
(has been removed in deno v2)
| const result = await Promise.race([onPort, onPortFile, onExit]); | ||
|
|
||
| if (isPortInfo(result)) { | ||
| if (!child.pid) throw new Error(`Failed to start dev server for "${entrypoint}" (PID is undefined)`) |
There was a problem hiding this comment.
in newer version of node:
Returns the process identifier (PID) of the child process. If the child process fails to spawn due to errors, then the value is undefined and error is emitted.
|
@TooTallNate sorry to ping you directly, but do you think it'd be possible to have a review about this eventually ? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.