Update history.tsx to use correct filter when deleting item from list
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is filtering based on id (from useParams() at the top), which is the ID of the chat currently being viewed in the URL, not the one being deleted. The code now correctly filters out the chat with the deleteId rather than the current URL id. This ensures that: 1. The correct chat is removed from the history list after deletion 2. The filter operation matches the chat being deleted rather than the currently viewed chat 3. The UI will update properly to reflect the deleted item
|
@scottybollinger is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is filtering based on id (from useParams() at the top), which is the ID of the chat currently being viewed in the URL, not the one being deleted.
The code now correctly filters out the chat with the deleteId rather than the current URL id.
This ensures that: