feat(ai): rootSpan flag for telemetry options #9309
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new flag `rootSpan` to `experimental_telemetry` that instructs to create a root span (detached from any parent) during the execution. Defaults to false keeping the current behavior. The reason to propose this is that currently I'm having a hard time getting telemetry to show up correctly in langfuse while using effect. Because the stream returned by stream operations exists outside the lifecycle of the calling function, traces get reported out of order, and ultimately certain attributes that should be made available to the root span never make it. So forcing the ai traces to be isolated isi the only way I've been able to sort of solve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The reason to propose this is that currently I'm having a hard time getting telemetry to show up correctly in langfuse while using effect.
Because the stream returned by stream operations exists outside the lifecycle of the calling function, traces get reported out of order, and ultimately certain attributes that should be made available to the root span never make it.
So forcing the ai traces to be isolated isi the only way I've been able to sort of solve it.
Summary
Adds a new flag
rootSpantoexperimental_telemetrythat instructs to create a root span (detached from any parent) during the execution. Defaults to false keeping the current behavior.Manual Verification
Tested a local build with my existing app
Checklist
pnpm changesetin the project root)pnpm prettier-fixin the project root)Future Work
Related Issues