-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for Natural Textures #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kynake
wants to merge
32
commits into
vfx-dev:master
Choose a base branch
from
Kynake:feature/natural-textures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add placeholder code that mirrors the UV
Add mixin prefix to some variables in Nat Textures mixin
Add placeholder use of configured HashMap
…ce names To keep backwards compatibility with older resourcepacks
- Simplify side and salt into one variable - Ensure salt gets mixed in to the hash from the very start
Was unused, can be re-added if ever needed in future
d63c35c to
72297f0
Compare
…ixin / module toggles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaturalTextures is not one of the features originally included in MCPatcher (though it is often conflated as one), but I heard that NotFine plans to remove it's resource pack features in the future, so I think this might be as good a place as any to add support for this.
If you feel that this feature is not a good fit for the mod then that's fine too, as I can convert this into a separate mod with a little extra work.
Pictures, with the feature off and on:


Best way to test this is to open up a dev instance on this branch and add the following resourcepack:
NaturalTextures.zip
This should toggle the rotation of grass and stone textures when enabling / disabling the
Modules/Natural Texturessetting.I still have a few things I'd like to improve on this, but I think that it's a good time to show my work, and also because the core of the code and mixins are ready enough for a review.
TODO list:
natural.propertiesto assets(template file supporting vanilla textures and maybe ones from Et Futurum Requiem and other backports)
(such as vines and crossed-squares blocks. Specific support might depend on the relevance that the block has with natural looking textures, and could be added later if the need arises)
UPDATE: Additional support added for vines, crossed square blocks (tall grass, flowers, saplings, etc) and crops
Sideclass instead ofForgeDirectionnatural.propertiesasset. Allow files from different resourcepacks to 'stack', like lang files do.(This is not a feature that the original Natural Textures supported, but would allow for texture packs to configure rotations for their own textures without overriding others, similar to how it works in modern MC. Also add a toggle for the old behavior)