fix compiler generated field conflict#3
Open
Truinto wants to merge 3 commits intovikigenius:masterfrom
Open
Conversation
remove sealed
Contributor
Author
|
Btw, I tried to also compile for net6 (or netstandard2.0). But I gave up after a couple hours. There are issues with ilrepack and with the Microsoft.Build.Framework dependency. Weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the compiler is allowed to generate private fields with identical names as existing events. Referencing the event will then cause a conflict, since the IDE doesn't know if you mean the field or the event.
I made it optional to have compiler generated fields set to public.
I also added a line to remove the sealed modifier from classes. I don't have a project to test this right now, but I think that shouldn't cause any problems.