docs: remove broken build.license example

[btea]

Keep it consistent with the default values ​​in the example code above.

[bluwy]

The reason I didn't do this is because (iirc) most static providers don't serve dot directories by default. I also placed it in .vite/ by default so we don't collide with other output files by default (and I guess frameworks may easily handle it?)

I just sent a PR showing an example of setting "license.md" in the features page though. #21071

[btea]

That makes sense.

I have another question: when I configure the banner as shown in the example below, the related comments don't appear in the actual output. It seems they've been removed by esbuild plugins. Is it possible to configure some options to retain the comments?

[bluwy]

Ah, that's unexpected. Esbuild probably stripped them off when we run it on each output chunks, so probably you'd have to configure the banner on the esbuild option instead to workaround, but I wonder if we should like pass build.rollupOptions.output.banner to esbuild.banner to make it work.

It would be great if you open an issue about this.

[btea]

Ah, that's unexpected. Esbuild probably stripped them off when we run it on each output chunks, so probably you'd have to configure the banner on the esbuild option instead to workaround, but I wonder if we should like pass build.rollupOptions.output.banner to esbuild.banner to make it work.

Yeah, that's what I think too.

It would be great if you open an issue about this.

#21076

[sapphi-red]

I wonder if we should like pass build.rollupOptions.output.banner to esbuild.banner to make it work.

This will not work with rolldown-vite as esbuild.banner is removed and oxc.banner does not exist. It has to use generateBundle hook to inject code/comments after minification (related: rolldown/rolldown#6790).

[bluwy]

This feels a bit tricky. Should we remove the tip for now since it's only showing an example setup? We probably should figure out better banner/footer support later with the new issue.

[btea]

I agree that the relevant examples should be removed first.

[sapphi-red]

Yeah, let's remove this for now

[thinkasany]

#21092