Skip to content

Conversation

hi-ogawa
Copy link
Contributor

Description

Related #7861

Just checking if any breaking change on Vitest environment level

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 20, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c56716
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/68047a6b4beb090008b92fe1
😎 Deploy Preview https://deploy-preview-7863--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asamuzaK
Copy link

asamuzaK commented May 5, 2025

Thanks for testing.
Let us know if there's anything we can do to help on the jsdom side.
jsdom/jsdom#3864

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented May 6, 2025

@asamuzaK Thanks for ping! v27 looks fine on Vitest repo though we don't have a many jsdom test case internally, so this is mostly to confirm basic Vitest environment usage. Also note that Vitest's peerDependencies doesn't pin jsdom version, so Vitest users are free to upgrade jsdom on their own anytime. This PR is only for devDependencies of this repo.

Once jsdom v27 becomes latest tag, renovate will probably raise a PR, so that's when we'll merge it for own repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants