-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(types): add better promise support in expects and matchers #8266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samchungy
wants to merge
28
commits into
vitest-dev:main
Choose a base branch
from
samchungy:promise-type-expects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−97
Open
Changes from 10 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
598b456
Add support for generics in Promise expects
samchungy 30d0ea9
Fix chai mocks
samchungy ebd8b28
re-sort
samchungy 6d1dd87
Add more type-checks
samchungy 12e6cbe
fix type
samchungy 7d0817e
add better types everywhere
samchungy b5fce0c
remove excess tests, add satisfies
samchungy d33353c
test main
samchungy d9200a3
Fix jest matchers
samchungy 5970454
Fix custom matcher promises
samchungy f010b0e
fix lint
samchungy 3e86af9
fix custom matcher types
samchungy ca4e273
fix test
samchungy e70ef25
fix test
samchungy 0856306
fix test
samchungy 0c5db4e
lint
samchungy 1cf2d40
fix test error
samchungy 28ea84e
add promises
samchungy 5d5d603
Avoid double wrapping promises
samchungy d8cbe2f
retry
samchungy f9f513a
revert AsymmetricMatchersContaining change
samchungy d1b379d
retry flakey tests
samchungy 3694a6b
retry flakey tests
samchungy 87ce1aa
fix chai case
samchungy b4da6c6
Merge branch 'main' of https://github.com/samchungy/vitest into promi…
samchungy 13d2175
Merge branch 'main' of github.com:vitest-dev/vitest into promise-type…
samchungy 61ff16b
rename
samchungy 7948286
rerun
samchungy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically breaking but this aligns more with how Jest works and makes more sense?
See: https://github.com/vitest-dev/vitest/pull/8266/files#diff-810c1bb9ffac48cfe14f7dbbaf10fdf5725e06feecb99c657d49f3c7712bcd00L197-R197
I think we may be incorrectly setting these as it seems like the intention is for
void
to be R and T to be set to E here.