Skip to content

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Sep 5, 2025

This reverts commit a8c7f73.

Description

We want to support EOL Node 18 too.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 58c7e16
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68ba81d7e0b7010008b3dafb
😎 Deploy Preview https://deploy-preview-8532--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@RobinTail
Copy link
Contributor

I don't think you should revert it, @AriPerkkio .
Node 18 is EOL and vitest 4 would be the next major release that implies breaking changes.
It is the good moment to drop the support of the outdated software.

@AriPerkkio
Copy link
Member Author

I agree 100%, but we need to support EOL Node 18 in Vitest 4.

@RobinTail
Copy link
Contributor

RobinTail commented Sep 5, 2025

Then I suggest to add tests against Node 18, @AriPerkkio
That would help to avoid similar issues

Screenshot 2025-09-05 at 10 55 03

Though, it looks like it was removed for a reason:
#8300

@AriPerkkio
Copy link
Member Author

Then I suggest to add tests against Node 18

Yup I agree completely.

@belgattitude
Copy link

Worth to bring to your attention

Seems that Tinypool v2 makes it possible to run vitest with latest bun: oven-sh/bun#4145 (comment)

@sheremet-va
Copy link
Member

sheremet-va commented Sep 22, 2025

We decided to remove support for node 18.

@AriPerkkio AriPerkkio deleted the fix/revert-tinypool-v2 branch September 22, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants