-
Notifications
You must be signed in to change notification settings - Fork 477
[API] stormservice support podgroup #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Epsilon314
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
Epsilon314:yiqing/github/podgroup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding these dependencies, do the strategies require these components or CRDs to run? For example, does the VolcanoSchedulingStrategy require the Volcano component to be installed to take effect? Also, do we need to integrate with Aibrix (is that a large dependency)? Or how can we check if the CRD exists?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imagine that if a user sets VolcanoSchedulingStrategy but doesn't have Volcano installed. What will the final be? Is there a fallback mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we check if prd exist before each podgroup create/delete (with dynamic client), and if crd do not exist we just stop there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative is to add a feature gate that requires user to choose the scheduler implementation if they want to enable podgroup, therefore we can check prd exist at start time and just crash and complain if it does not (if crd is determined at start time we can add it to informer which is a plus).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a feature gate approach is a good option. Regarding the CRD check, I understand we can this check crd when starting controller. If fg=true, users should install the corresponding component(like volcano...). We could implement this similarly.
FYI: https://github.com/Jeffwan/aibrix/blob/1008ec3260f0a85f573c45d0a6487080f10758b1/pkg/controller/controller.go#L62-L73
Also, if pg creation fails, we could throw an appropriate log or event to notify the user.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tradeoff is
pro: since crd is known at start time, we can add it to schema therefore watching and modification will be easier;
cons: since there is no obvious default value users have to config it explicitly, thus is not enabled out-of-box
pro: config free, take effect immediately after scheduler is installed
cons: hard to watch podgroup change; more apicall
after rethink i feel like adding a feature gate would be a better choice , and we can simplify the added configuration complexity in release part for example some helm tricks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI:
InftyAI/llmaz#316 (comment)