Skip to content

Conversation

jiangxiaobin96
Copy link
Contributor

@jiangxiaobin96 jiangxiaobin96 commented Sep 7, 2025

Pull Request Description

when diff <= len(notReady), we only need to delete the first diff rolesets which are all not ready.

if diff <= len(notReady) {
	toDelete = notReady[:diff]
	count, err := r.deleteRoleSet(toDelete)
	if err != nil {
		return false, err
	}
	klog.Infof("%s/%s successfully delete %d roleSets", stormService.Namespace, stormService.Name, count)
	return false, nil
}

And when diff > len(notReady), we already have diff rolesets to delete and only need to delete diff -= len(notReady) rolesets. The original logic directly calculates expected roleset without diff, so I remove by proportion based on diff count.

expectDeleteCurrentReplica, expectDeleteUpdatedReplica := calculateReplicas(int32(diff), int32(len(currentReady)), int32(len(updatedReady)))
toDelete = append(toDelete, currentReady[:expectDeleteCurrentReplica]...)
toDelete = append(toDelete, updatedReady[:expectDeleteUpdatedReplica]...)

Original logic is not bug, just different calculation methods. Please check if it is necessary to refine, thanks.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jiangxiaobin96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the stormservice scaling mechanism to ensure accurate and proportional reduction of RoleSets during scale-down operations. It specifically addresses a scenario where the required number of deletions exceeds the available notReady instances, preventing unintended over-deletion by distributing the remaining deletions across currentReady and updatedReady instances based on their proportions.

Highlights

  • StormService Scaling Logic: Corrected the scaling down logic for stormservice when the desired replica difference (diff) is greater than the number of notReady RoleSets.
  • Proportional RoleSet Deletion: Introduced a proportional calculation to determine the number of currentReady and updatedReady RoleSets to delete, ensuring the total deleted count matches the remaining diff.
  • Code Cleanup: Removed a TODO comment that highlighted the previous incorrect usage of the diff variable in the scaling logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the scaling-down logic for StormService when a rollout is paused. The change aims to proportionally delete ready RoleSets from both current and updated revisions based on the required reduction (diff). While the approach of using diff to determine the number of replicas to delete is clearer, the implementation has a flaw in its rounding logic that could lead to deleting more replicas than intended. I've provided a specific comment with a suggested fix that reuses an existing utility function to handle the proportional calculation and rounding correctly.

@jiangxiaobin96
Copy link
Contributor Author

jiangxiaobin96 commented Sep 8, 2025

It is not a bug, just modify logic to use diff value. The result is the same with now. Confirm if it is necessary.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 18, 2025

@jiangxiaobin96 thanks for the change, I will double check the necessity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants