-
Notifications
You must be signed in to change notification settings - Fork 467
[Feature] Add Session-Aware Logic in Gateway #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Feature] Add Session-Aware Logic in Gateway #1633
Conversation
…arsing for session ID
- Removed old session cache tests and implementation. - Added new `SessionCache` interface for session state management. - Implemented `MutexSessionCache` for low to medium concurrency using mutexes. - Implemented `ShardedSessionCache` for high concurrency using sharding and channels. - Created comprehensive test suite for both cache implementations, ensuring compliance with the `SessionCache` interface. - Added benchmarks to compare performance between mutex and sharded implementations. - Included cleanup routines to manage stale sessions effectively.
Summary of ChangesHello @SleepyLGod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AIBrix Gateway by integrating a sophisticated session-aware scheduling system. The core change involves transitioning from a basic prefix-cache router to a state machine-driven request processing flow, which leverages a new scheduler and session cache. This new architecture enables intelligent prioritization of requests based on session history, dynamic adjustment of processing capacity, and improved resource utilization, ultimately aiming to boost throughput and reduce latency for conversational AI applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant architectural improvement by adding a session-aware scheduler and refactoring the request processing logic into a state machine. The new scheduler is designed for high performance using non-blocking channels, and the session caching has both simple and advanced sharded implementations. The overall design is robust and well-tested. My review focuses on a critical issue with the legacy processing path which appears to be broken by the changes, a point where error handling for clients can be improved, and a minor issue with log levels.
Pull Request Description
Current AIBrix Gateway uses a prefix-cache-aware router to route single LLM requests.
This PR is responsible for implementing session tracking and session-aware scheduling (and routing) within the Gateway.
Related Issues
Resolves: #633 #1248
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.