[Misc] Added unit test for WorkloadScale #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurali-techie
changed the title
|
@googs1025 @Jeffwan I have added two unit tests related to workload scale. Can you plz check and confirm that is this the kind of unit tests make sense for workload scale? I am planning to add more such unit tests in this PR. Thank you. |
|
leave this to @googs1025 for review. |
nurali-techie
force-pushed
the
nur/patch-workload-scale-test
branch
from
a3db5d6 to
afa81cf
Compare
|
@googs1025 this PR is ready for review. I have added all postive unit tests for |
nurali-techie
changed the title
nurali-techie
changed the title
nurali-techie
force-pushed
the
nur/patch-workload-scale-test
branch
from
afa81cf to
7058a35
Compare
nurali-techie
changed the title
googs1025
approved these changes
Oct 17, 2025
Signed-off-by: Nurali Techie <[email protected]>
Signed-off-by: Nurali Techie <[email protected]>
googs1025
force-pushed
the
nur/patch-workload-scale-test
branch
from
7058a35 to
9c2ac9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
To improve coverage for podautoscaler, added unit tests for
WorkloadScale.GetCurrentReplicasFromScale().Related Issues
Resolves: part of [#1649] (
GetCurrentReplicasFromScale()andGetPodSelectorFromScale()unit tests)Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.