Features/add model size to the UI #391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dalthecow <[email protected]>
|
🎉 Live Preview: Click here to view the live version |
DaltheCow
changed the title
sjmonson
requested changes
Oct 10, 2025
Collaborator
sjmonson
left a comment
sjmonson
left a comment
There was a problem hiding this comment.
One question, just resolve it and I'll approve
| bm.run_stats.start_time for bm in benchmarks if bm.start_time is not None | ||
| ) | ||
| response = httpx.get(f"https://huggingface.co/api/models/{model}") | ||
| model_json = response.json() |
Collaborator
There was a problem hiding this comment.
Is this safe from an error response?
Collaborator
Author
There was a problem hiding this comment.
I'm splitting time between this team and another team now but I will get to this. Definitely need to handle an error response
sjmonson
added a commit
that referenced
this pull request
Oct 10, 2025
feature/ui/add-dataset-and-model-size
Signed-off-by: dalthecow <[email protected]>
Signed-off-by: dalthecow <[email protected]>
Signed-off-by: dalthecow <[email protected]>
Signed-off-by: dalthecow <[email protected]>
DaltheCow
changed the title
Signed-off-by: dalthecow <[email protected]>
…uralmagic/guidellm into feature/ui/add-dataset-and-model-size
Signed-off-by: dalthecow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The run info will now grab the model size if the model is pulled from HF
Details