Initial PR for performance test on integration test that running on CI #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Senan Zedan <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Member
|
fixes: #41 |
Signed-off-by: Senan Zedan <[email protected]>
The PR comment step can fail when running on pull requests from forks due to GitHub's security restrictions. Even with write permissions specified, GITHUB_TOKEN is read-only for fork PRs to prevent malicious code from writing to the base repository. Added 'continue-on-error: true' to make this step optional. The performance results will still be available in the workflow artifacts even if commenting fails. Fixes the '403 Resource not accessible by integration' error on fork PRs. Signed-off-by: Senan Zedan <[email protected]>
Collaborator
Author
|
@Xunzhuo - Could you please review |
Collaborator
|
merging it for testing now |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intial PR for performance test on integration test and generate report.