Skip to content

Conversation

@liziyu179
Copy link
Contributor

@liziyu179 liziyu179 commented Sep 4, 2025

What this PR does / why we need it?

Remove useless PD check in deepseek

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes hardcoded logic related to prefill/decode disaggregation, where the with_prefill flag was forced to specific values based on whether a node was a kv_producer or kv_consumer. While this simplifies the code by relying on the caller-provided context, it may introduce issues. Specifically, the changes could lead to incorrect behavior during profiling and graph capture for producer and consumer nodes in a disaggregated setup, as the assumptions about their roles during dummy runs seem to be violated. I've added two comments highlighting these potential issues.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.99%. Comparing base (984bd7c) to head (1b1da92).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
+ Coverage   72.57%   72.99%   +0.42%     
==========================================
  Files         150      153       +3     
  Lines       21372    21331      -41     
==========================================
+ Hits        15511    15571      +60     
+ Misses       5861     5760     -101     
Flag Coverage Δ
unittests 72.99% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan wangxiyuan changed the title PD disaggregate should not force with_prefill true in P and false in D [Misc] Remove useless PD check in deepseek Sep 4, 2025
@wangxiyuan wangxiyuan merged commit 4c90fa7 into vllm-project:main Sep 4, 2025
25 checks passed
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Sep 10, 2025
### What this PR does / why we need it?
Remove useless PD check in deepseek


- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@6c7af81

---------

Signed-off-by: liziyu <[email protected]>
offline893 pushed a commit to offline893/vllm-ascend that referenced this pull request Sep 16, 2025
### What this PR does / why we need it?
Remove useless PD check in deepseek

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@6c7af81

---------

Signed-off-by: liziyu <[email protected]>
Signed-off-by: offline0806 <[email protected]>
wangxiaoteng888 pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Sep 25, 2025
### What this PR does / why we need it?
Remove useless PD check in deepseek


- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@6c7af81

---------

Signed-off-by: liziyu <[email protected]>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
Remove useless PD check in deepseek

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@6c7af81

---------

Signed-off-by: liziyu <[email protected]>
@liziyu179 liziyu179 deleted the pd_with_prefill branch September 28, 2025 02:37
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Remove useless PD check in deepseek


- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@6c7af81

---------

Signed-off-by: liziyu <[email protected]>
@liziyu179 liziyu179 changed the title [Misc] Remove useless PD check in deepseek [P/D] [Misc] Remove useless PD check in deepseek Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants