-
Notifications
You must be signed in to change notification settings - Fork 592
[P/D] [Misc] Remove useless PD check in deepseek #2739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: liziyu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes hardcoded logic related to prefill/decode disaggregation, where the with_prefill flag was forced to specific values based on whether a node was a kv_producer or kv_consumer. While this simplifies the code by relying on the caller-provided context, it may introduce issues. Specifically, the changes could lead to incorrect behavior during profiling and graph capture for producer and consumer nodes in a disaggregated setup, as the assumptions about their roles during dummy runs seem to be violated. I've added two comments highlighting these potential issues.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2739 +/- ##
==========================================
+ Coverage 72.57% 72.99% +0.42%
==========================================
Files 150 153 +3
Lines 21372 21331 -41
==========================================
+ Hits 15511 15571 +60
+ Misses 5861 5760 -101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: liziyu <[email protected]>
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <[email protected]>
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <[email protected]> Signed-off-by: offline0806 <[email protected]>
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <[email protected]>
Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <[email protected]>
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <[email protected]>
What this PR does / why we need it?
Remove useless PD check in deepseek