-
Notifications
You must be signed in to change notification settings - Fork 51
Fix issue with async_scheduling when dealing with chunked input #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.10.2_next
Are you sure you want to change the base?
Fix issue with async_scheduling when dealing with chunked input #359
Conversation
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Signed-off-by: Tianmu Li <[email protected]>
1f87a51
to
09c183d
Compare
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
@afierka-intel Can you check if this fixes the issue with long context? It works from my tests. |
/run-gaudi-tests |
1 similar comment
/run-gaudi-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cherrypick to 0.11 also
/run-gaudi-tests |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
/run-gaudi-tests |
/run-gaudi-tests |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
/run-gaudi-tests |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
When dealing with chunked prompt (input sequence length > max_num_batched_tokens), sometimes there is no output token due to the chunked prompt, but the scheduler expects one. This PR addresses this issue and aligns the behavior with gpu_model_runner.