[CB] consistent max context length #514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a (known) inconsistency: Allowing the additional token in
platform.validate_request
, but not inscheduler.can_schedule()
(#332 would allow it in the scheduler). However, as the upstream vllm version vllm-spyre is tied to does not currently allow the additional token, this PR removes the inconsistency and establishes same behavior as upstream.Note: as soon as the upstream version tied to this repo allows the additional token, we can revert this PR and merge #332 (along with some unit tests).
cc @sducouedic