Skip to content

Conversation

@tjohnson31415
Copy link
Collaborator

@tjohnson31415 tjohnson31415 commented Nov 21, 2025

Description

There was a bug in the scheduler that woud cause no request to be scheduled, putting the scheduler in an infinite loop. This occurred when a very large context-request was being prefilled. When checking _satisfies_last_chunk_constraints, it would say it is unscheduleable becuase it compared the remaining TKV against a copy of itself, exceeding the max_content_len. But it was also the only request running and so nothing would be scheduled.

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. As soon as the testing PR is in a working state I'll change the max model len to the value that reproduces this problem before your fix.

Copy link
Collaborator

@wallashss wallashss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and validated.

@maxdebayser maxdebayser merged commit aecfba1 into main Nov 24, 2025
20 checks passed
@maxdebayser maxdebayser deleted the fix-no-schedule-bug branch November 24, 2025 17:43
maxdebayser added a commit that referenced this pull request Nov 24, 2025
to reproduce the conditions of the bug that PR #576 fixes
(fix: check only decoding requests in _satisfies_last_chunk_constraints)

Signed-off-by: Max de Bayser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants