Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 26, 2025

This reverts commit d63cd9f.

Purpose

See #27522 (comment)

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Oct 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change that moved some multi-modal tests to a CPU runner. The revert seems to be motivated by an issue with test_mapping.py on CPU. While moving test_mapping.py back to a GPU runner is correct, the full revert also moves processing tests back to GPU, which is likely unnecessary and inefficient. My review includes a suggestion to perform a more targeted fix to keep the processing tests on a CPU runner to save resources.

Comment on lines +736 to 743
- label: Multi-Modal Processor Test # 44min
timeout_in_minutes: 60
no_gpu: true
source_file_dependencies:
- vllm/
- tests/models/multimodal
commands:
- pip install git+https://github.com/TIGER-AI-Lab/Mantis.git
- pytest -v -s models/multimodal/processing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this revert correctly moves test_mapping.py back to a GPU-enabled test step, it also moves the models/multimodal/processing tests to a GPU runner. The title of the original PR being reverted ('[CI/Build] Use CPU for mm processing test on CI') suggests that these processing tests can run on CPU.

To optimize CI resource usage and costs, it would be better to keep these tests on a CPU-only runner. You can achieve this by re-introducing no_gpu: true to this step and updating the label to reflect it runs on CPU.

  - label: Multi-Modal Processor Test (CPU) # 44min
    timeout_in_minutes: 60
    no_gpu: true
    source_file_dependencies:
    - vllm/
    - tests/models/multimodal
    commands:
      - pip install git+https://github.com/TIGER-AI-Lab/Mantis.git
      - pytest -v -s models/multimodal/processing

@Isotr0py Isotr0py enabled auto-merge (squash) October 26, 2025 11:42
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 26, 2025
@vllm-bot vllm-bot merged commit c7abff2 into main Oct 26, 2025
13 of 23 checks passed
@vllm-bot vllm-bot deleted the revert-27522 branch October 26, 2025 11:44
xuhaolei pushed a commit to ZJU-REAL/EasySteer-vllm-v1 that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants