Revert "[CI/Build] Use CPU for mm processing test on CI (#27522)" #27531
Conversation
This reverts commit d63cd9f. Signed-off-by: DarkLight1337 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that moved some multi-modal tests to a CPU runner. The revert seems to be motivated by an issue with test_mapping.py on CPU. While moving test_mapping.py back to a GPU runner is correct, the full revert also moves processing tests back to GPU, which is likely unnecessary and inefficient. My review includes a suggestion to perform a more targeted fix to keep the processing tests on a CPU runner to save resources.
| - label: Multi-Modal Processor Test # 44min | ||
| timeout_in_minutes: 60 | ||
| no_gpu: true | ||
| source_file_dependencies: | ||
| - vllm/ | ||
| - tests/models/multimodal | ||
| commands: | ||
| - pip install git+https://github.com/TIGER-AI-Lab/Mantis.git | ||
| - pytest -v -s models/multimodal/processing |
There was a problem hiding this comment.
While this revert correctly moves test_mapping.py back to a GPU-enabled test step, it also moves the models/multimodal/processing tests to a GPU runner. The title of the original PR being reverted ('[CI/Build] Use CPU for mm processing test on CI') suggests that these processing tests can run on CPU.
To optimize CI resource usage and costs, it would be better to keep these tests on a CPU-only runner. You can achieve this by re-introducing no_gpu: true to this step and updating the label to reflect it runs on CPU.
- label: Multi-Modal Processor Test (CPU) # 44min
timeout_in_minutes: 60
no_gpu: true
source_file_dependencies:
- vllm/
- tests/models/multimodal
commands:
- pip install git+https://github.com/TIGER-AI-Lab/Mantis.git
- pytest -v -s models/multimodal/processing
github-actions
bot
added
the
ready
…#27522)" (vllm-project#27531) Signed-off-by: DarkLight1337 <[email protected]>
…#27522)" (vllm-project#27531) Signed-off-by: DarkLight1337 <[email protected]>
…#27522)" (vllm-project#27531) Signed-off-by: DarkLight1337 <[email protected]>
…#27522)" (vllm-project#27531) Signed-off-by: DarkLight1337 <[email protected]>
This reverts commit d63cd9f.
Purpose
See #27522 (comment)
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.