Skip to content

[Frontend] Fix logging format when enable response logging #28049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2025
+1 −2
Merged

[Frontend] Fix logging format when enable response logging #28049

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
188a96a
Fix blocking and log when enable logging
esmeetu Nov 4, 2025
17f5efb
revert tuple
esmeetu Nov 4, 2025
9ca90de
apply suggestion
esmeetu Nov 4, 2025
148d894
revert blocking fix
esmeetu Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions vllm/entrypoints/openai/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,8 +1578,7 @@ def buffered_iterator():
full_content = full_content[:2048] + ""
"...[truncated]"
logger.info(
"response_body={streaming_complete: "
"content='%s', chunks=%d}",
"response_body={streaming_complete: content=%r, chunks=%d}",
Copy link
Member

@markmc markmc Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a nitpick - but the single quotes surrounding the content does aid readability, so let's add those back? 👍

Copy link
Member Author

@esmeetu esmeetu Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point — adding quotes manually will actually result in double quotes like:

response_body={streaming_complete: content=''...''}

Using %r already preserves the quotes automatically for readability.

response_body={streaming_complete: content='...'}

full_content,
chunk_count,
)
Expand Down
Loading