[BugFix] Fix DBO failing with TypeError: 'NoneType' object is not iterable #29698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a TypeError in the DBO logic by adding a missing return statement. The change is correct and resolves the issue. I have added one comment with suggestions for further improving code quality and maintainability in the affected function.
LucasWilkinson
added
the
ready
ProExpertProg
approved these changes
Nov 28, 2025
Collaborator
Author
|
NVM its flaky; holding off for now |
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
LucasWilkinson
force-pushed
the
lwilkinson/fix-dbo
branch
from
95c9780 to
a1aedc6
Compare
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…rable (vllm-project#29698) Signed-off-by: Lucas Wilkinson <[email protected]>
amd-hhashemi
pushed a commit
to amd-hhashemi/vllm
that referenced
this pull request
Dec 2, 2025
…rable (vllm-project#29698) Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Hashem Hashemi <[email protected]>
minosfuture
added a commit
to minosfuture/vllm
that referenced
this pull request
Dec 4, 2025
… not iterable (vllm-project#29698)" This reverts commit e23f665.
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
…rable (vllm-project#29698) Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Dec 6, 2025
…rable (vllm-project#29698) Signed-off-by: Lucas Wilkinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28579 broke DBO but was hidden by existing test failures on the nightly (#28893, with those fixed this now showed up)
Test Plan:
Fails on Main, Passes on this PR
NOTE: using
padded_second_ubatch_sliceinstead ofubatch_slices[1].request_slicefor requests was a bug that pre-dated #28579 but was just exacerbated by it