Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Conversation

@juanmendes
Copy link
Contributor

@juanmendes juanmendes commented Dec 21, 2022

Updating so that VCD UI can update its RXJs version

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Examples have been added / updated (for bug fixes / features)
  • Changelog has been updated

PR Type

What kind of change does this PR introduce?

  • Version bump (RXJS)

What does this change do?

What manual testing did you do?

  • Ran the examples container's SubscriptionTracker example
    • Ensured subscriptions are no longer active when a component is destroyed (and no logging on the console happens)

Screenshots (if applicable)

Does this PR introduce a breaking change?

  • Yes

Other information

Remove usages of toSubscriber()

Signed-off-by: Juan Mendes <[email protected]>
@juanmendes juanmendes changed the title Draft: remove usages of toSubscriber() Update RXJS - version 7.8 Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant