-
Notifications
You must be signed in to change notification settings - Fork 36
Feat/faq #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/faq #63
Changes from 8 commits
1575621
05fb2fb
4417450
2e3bba5
f50d254
370214d
00efe59
1f5f879
7f8506d
32a3833
65e0b60
f4afebb
3adca70
0704bc4
389d7dc
066f28b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { NgModule } from '@angular/core'; | ||
| import { Routes, RouterModule } from '@angular/router'; | ||
| import { FaqComponent } from '@pages/faq/faq.component'; | ||
| import { MainComponent } from '@pages/main/main.component'; | ||
|
|
||
| const routes: Routes = [ | ||
| { path: '', component: MainComponent }, | ||
| { path: 'faq', component: FaqComponent }, | ||
| { | ||
| path: '**', | ||
| redirectTo: '', | ||
| }, | ||
| ]; | ||
|
|
||
| @NgModule({ | ||
| imports: [RouterModule.forRoot(routes)], | ||
| exports: [RouterModule], | ||
| }) | ||
| export class AppRoutingModule {} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| h6 { | ||
| color: #c10707; | ||
| font-size: 20px; | ||
| } | ||
|
|
||
| a { | ||
| color: #c10707; | ||
| } | ||
|
|
||
| .text-container { | ||
| margin-left: 15%; | ||
| margin-right: 15%; | ||
| color: #333; | ||
| } | ||
|
|
||
| .text-content { | ||
| font-weight: 400; | ||
| line-height: 1.5; | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| .question { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should make the design responsive |
||
| margin: 20px; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| <div class="text-container"> | ||
| <div class="text-content"> | ||
| <div class="question"> | ||
| <h6>What is Angular-Communities?</h6> | ||
| <p> | ||
| Angular-communities in an initiative born in Málaga, Spain. It started as a small | ||
| open-source project built by four Angular devs from Málaga (see about us for more info) who | ||
| aimed to create a space where every single Angular community out there could be found and | ||
| located on the world map. This way, the visibility of all the Angular communities around the | ||
| world is increased, which is always a good thing! As more and more community members started | ||
| to show interest in Angular-Communities, our small project began to grow. Our goal now is to | ||
| create a space where all information regarding Angular can be found: communities, | ||
| conferences, events... | ||
| </p> | ||
| </div> | ||
| <div class="question"> | ||
| <h6>I host an Angular community, can I add it to Angular-Communities?</h6> | ||
| <p>Of course! We're looking forwards to adding your community.</p> | ||
| </div> | ||
| <div class="question"> | ||
| <h6>Can Angular conferences/events like ngSpain, ngConf etc. be added too?</h6> | ||
| <p> | ||
| We're working on also adding all the Angular events! Would you like to help us out? You can | ||
| find more information | ||
| <a target="_blank" href="https://github.com/voidcosmos/angular-communities/issues/42" | ||
| >here</a | ||
| >. | ||
| </p> | ||
| </div> | ||
| <div class="question"> | ||
| <h6>How do I add my community to Angular-Communities?</h6> | ||
| <p> | ||
| All you need to do is open a PR, filling in the required fields with the information about | ||
| your community. We'll review it, and if all is well, your community will be added! For more | ||
| info, see | ||
| <a target="_blank" href="https://github.com/voidcosmos/angular-communities" | ||
| >the Angular-Communities README.</a | ||
| > | ||
| </p> | ||
| </div> | ||
| <div class="question"> | ||
| <h6>Can I participate in the Angular-Communities project?</h6> | ||
| <p> | ||
| Of course you can! Any help at all is very welcome. See the following question for | ||
| information on how to contribute. | ||
| </p> | ||
| </div> | ||
| <div class="question"> | ||
| <h6>How can I contribute to the Angular-Communities project?</h6> | ||
| <p> | ||
| You can find all the information related to contributing | ||
| <a | ||
| target="_blank" | ||
| href="https://github.com/voidcosmos/angular-communities/blob/master/.github/CONTRIBUTING.md" | ||
| >here</a | ||
| >. | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </div> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { Component } from "@angular/core"; | ||
|
|
||
| @Component({ | ||
| selector: "app-faq", | ||
| templateUrl: "./faq.component.html", | ||
| styleUrls: ["./faq.component.css"] | ||
| }) | ||
| export class FaqComponent {} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| import { NgModule } from '@angular/core'; | ||||||
| import { CommonModule } from '@angular/common'; | ||||||
| import { SharedModule } from '@shared/shared.module'; | ||||||
| import { FlexLayoutModule } from '@angular/flex-layout'; | ||||||
| import { ReactiveFormsModule } from '@angular/forms'; | ||||||
| import { MatInputModule } from '@angular/material/input'; | ||||||
| import { FaqComponent } from './faq.component'; | ||||||
|
|
||||||
| const COMPONENTS = [FaqComponent]; | ||||||
|
|
||||||
| @NgModule({ | ||||||
| declarations: [...COMPONENTS], | ||||||
|
||||||
| declarations: [...COMPONENTS], | |
| declarations: [COMPONENTS], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, my mistake for copy-pasting 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixed in 32a3833
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the modules are imported via shared, can be removed 👍
| imports: [CommonModule, SharedModule, FlexLayoutModule, ReactiveFormsModule, MatInputModule], | |
| imports: [SharedModule], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, those modules shouldn't even be imported in faqModule anyway. My mistake, for copy-pasting xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 32a3833
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,6 +2,7 @@ import { ActivatedRoute, Router } from '@angular/router'; | |||||
| import { Community, Communities } from '@shared/interfaces'; | ||||||
| import { Component, Input } from '@angular/core'; | ||||||
| import { map } from 'rxjs/operators'; | ||||||
| import { CommunityService } from '@shared/services'; | ||||||
|
|
||||||
| @Component({ | ||||||
| selector: 'ngcommunity-main', | ||||||
|
|
@@ -10,11 +11,17 @@ import { map } from 'rxjs/operators'; | |||||
| }) | ||||||
| export class MainComponent { | ||||||
| @Input() | ||||||
| communities: Communities; | ||||||
| /* communities: Communities; */ | ||||||
| communitie$ = this.communityService.communities; | ||||||
|
||||||
| community$ = this.route.fragment.pipe(map(community => this.communitie$[community])); | ||||||
|
||||||
| community$ = this.route.fragment.pipe(map(community => this.communitie$[community])); | |
| community$ = this.route.fragment.pipe(withLatestFrom(this.communitie$), map(([community, communities]) => communities[community])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed in 65e0b60
Caballerog marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,9 +6,10 @@ | |
| alt="Angular communities logo" | ||
| src="assets/images/angular-communities-logo_md.png" | ||
| /> | ||
| <span>ANGULAR COMMUNITIES</span> | ||
| <a routerLink="">ANGULAR COMMUNITIES</a> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👏👏 |
||
| </div> | ||
| <div> | ||
| <a class="menu" routerLink="/faq">FAQ</a> | ||
| <a | ||
| href="https://www.github.com/voidcosmos/angular-communities" | ||
| target="_blank" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FAQ module can be built in a lazy way