Skip to content

Conversation

@PercussiveElbow
Copy link

Useful if you don't want everyone to be able to interact with the bot.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋,

Thanks for reaching out and your submission. The implementation looks pretty clean, but please still consider starting a discussion or issue next before a PR to smoothen the process.

Generally, this feature looks very Slack-specific. I feel like the user management should be happening inside Slack, not here. There might already be a way to do this. Have you looked into this and maybe mind sharing your findings?

Other than that, this should be SLACK_ALLOWED_USERS with a prefix, and we try to avoid black-and-white terms largely.

Best
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants