Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 19 20 +1
Lines 375 400 +25
Branches 32 33 +1
=====================================
- Misses 375 400 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jorgenfj
requested changes
Feb 25, 2026
| ///////////////////////////// | ||
| namespace vortex::image_filtering { | ||
| struct TemporalNoiseParams { | ||
| int dontknow; |
Comment on lines
+14
to
+15
| double power_law_weight; | ||
|
|
Contributor
There was a problem hiding this comment.
Should document somewhere what this does
Comment on lines
+30
to
+31
| mutable bool has_prev_; | ||
| }; |
Contributor
There was a problem hiding this comment.
mutable bool has_prev_{false};
Comment on lines
+56
to
+57
| apply_erosion(filtered, temp, erotion_size); | ||
| apply_dilation(temp, filtered, dilation_size); |
Contributor
There was a problem hiding this comment.
Here you can pass in filtered for both src and dst in both these calls.
| temp.copyTo(filtered); | ||
| } else { | ||
| cv::addWeighted(temp, 0.5, previous_, 0.5, 0.0, filtered); | ||
| previous_ = temp.clone(); // update for next call |
Contributor
There was a problem hiding this comment.
should avoid .clone() because it allocates a new buffer
| apply_auto_gamma(temp, power_law_weight); | ||
|
|
||
| if (!has_prev_) { | ||
| has_prev_ = true; |
Contributor
There was a problem hiding this comment.
Makes sense to move this after previous has been assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the temporal noise filter for sonar images.