Skip to content

Add monitor flag to common DO service deployment #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+32 −18
Draft

Add monitor flag to common DO service deployment #437

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4092f07
add monitor flag to common DO service deployment
CamronStaley Sep 24, 2025
08a19ca
support helm
CamronStaley Sep 24, 2025
571d380
test: temporarily update tests to resolve failures
CamronStaley Sep 24, 2025
3b4c463
test: update tags
CamronStaley Sep 24, 2025
f4f13e3
docs: add env var readme for DO expiration timeout
CamronStaley Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/common-services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ services:
deploy:
replicas: ${FIFTYONE_DELEGATED_OPERATOR_WORKER_REPLICAS:-3}
command: >
/bin/sh -c "fiftyone delegated launch -t remote"
/bin/sh -c "fiftyone delegated launch -t remote -m"
environment:
API_URL: ${API_URL}
FIFTYONE_DATABASE_ADMIN: false
Expand Down
2 changes: 1 addition & 1 deletion docker/docs/configuring-gpu-workloads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ services:
teams-do-with-gpu:
image: voxel51/fiftyone-teams-cv-full:v2.11.1
command: >
/bin/sh -c "fiftyone delegated launch -t remote -n 'teams-do-with-gpu'"
/bin/sh -c "fiftyone delegated launch -t remote -n 'teams-do-with-gpu' -m"
environment:
API_URL: ${API_URL}
FIFTYONE_DATABASE_ADMIN: false
Expand Down
1 change: 1 addition & 0 deletions helm/fiftyone-teams-app/templates/delegated-operator-instance-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ spec:
{{- if ($v.description | default $defaultDescription) }}
- -d
- {{ ($v.description | default $defaultDescription) | quote }}
- -m
{{- end }}
securityContext:
{{- toYaml (merge (dict) ($v.securityContext | default dict) ($baseTpl.securityContext)) | nindent 12 }}
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/helm/delegated-operator-instance-deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4937,6 +4937,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do",
"-d",
"Long running operations delegated to teams-do",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -4959,6 +4960,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do",
"-d",
"Long running operations delegated to teams-do",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -4972,6 +4974,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do-two",
"-d",
"Long running operations delegated to teams-do-two",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -4995,6 +4998,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do",
"-d",
"Long running operations delegated to teams-do",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -5008,6 +5012,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do-two",
"-d",
"Long running operations delegated to teams-do-two",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -5030,6 +5035,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do",
"-d",
"Used for non-gpu workloads",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -5043,6 +5049,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do-two",
"-d",
"Long running operations delegated to teams-do-two",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -5066,6 +5073,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do",
"-d",
"Used for non-gpu workloads",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand All @@ -5079,6 +5087,7 @@ func (s *deploymentDelegatedOperatorInstanceTemplateTest) TestContainerCmdArgs()
"teams-do-two",
"-d",
"Long running operations delegated to teams-do-two",
"-m",
}
s.Equal(expectedArgs, args, "Args should be equal")
},
Expand Down
Loading