Skip to content

Rework PR/MR feature #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 21 commits into from
Oct 8, 2021
+869 −265
Merged

Rework PR/MR feature #219

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1b4cd4c
Tests: Move PR/MR related features to a dedicated file
bittner Aug 6, 2020
7aa59da
Tests: Add a PR/MR scenario when no credentials are given
neomilium Jan 3, 2021
1eb4c21
Tests: Add a PR/MR scenario with modules from GitHub and GitLab
neomilium Jan 3, 2021
af833b3
Refactor PR/MR related code (1/2)
neomilium Dec 31, 2020
ed8e4d2
Refactor PR/MR related code (2/2)
neomilium Jan 1, 2021
1173a47
Spec: Use multiline notation in GitHub specs
neomilium Jan 1, 2021
29f5841
Spec: Use rspec context in GitHub and GitLab specs
neomilium Jan 1, 2021
3fecd3e
Tests: Add PR scenarios with same target and source branches
neomilium Jan 3, 2021
61990db
Rework PR/MR related code (1/2)
neomilium Jan 1, 2021
51cb45a
CLI: Fix PR default target branch
neomilium Jan 1, 2021
d035941
PR/MR: Output PR/MR intent only when relevent in noop
neomilium Jan 1, 2021
b57f9e2
Tests: Fix PR/MR feature tests
neomilium Apr 21, 2021
44b6260
Rework PR/MR related code (2/2)
neomilium Dec 31, 2020
3fbe1b5
Rubocop: Update autogenerated todo file
neomilium Apr 23, 2021
a476c95
Spec: Add a minimal spec file for SourceCode
neomilium Apr 23, 2021
ce795d5
GitService: Improve hostname extraction
neomilium Oct 5, 2021
bb02241
GitService: Raises error about missing credentials only on instantiation
neomilium Oct 5, 2021
ba59519
GitService: Move factory part into dedicated module
neomilium Oct 6, 2021
57a715a
Tests: Use example.com according to RFC2606
neomilium Oct 6, 2021
a3bf16f
GitService: Define a protected #_open_pull_request method
neomilium Oct 6, 2021
57ebbb4
GitServices: Clean up requirements
neomilium Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions features/update/pull_request.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ Feature: Create a pull-request/merge-request after update
github: {}
"""
And I set the environment variables to:
| variable | value |
| GITHUB_TOKEN | foobar |
| variable | value |
| GITHUB_TOKEN | foobar |
| GITHUB_BASE_URL | https://github.faker.com |
And a file named "config_defaults.yml" with:
"""
---
Expand All @@ -32,7 +33,9 @@ Feature: Create a pull-request/merge-request after update
"""
---
puppet-test:
gitlab: {}
gitlab: {
base_url: 'https://gitlab.faker.com'
}
"""
And I set the environment variables to:
| variable | value |
Expand All @@ -59,7 +62,9 @@ Feature: Create a pull-request/merge-request after update
"""
---
puppet-test:
gitlab: {}
gitlab: {
base_url: 'https://gitlab.faker.com'
}
"""
And I set the environment variables to:
| variable | value |
Expand All @@ -75,7 +80,9 @@ Feature: Create a pull-request/merge-request after update
"""
---
puppet-test:
gitlab: {}
gitlab: {
base_url: https://gitlab.faker.com
}
"""
And a file named "config_defaults.yml" with:
"""
Expand All @@ -100,9 +107,11 @@ Feature: Create a pull-request/merge-request after update
---
puppet-github:
github:
base_url: https://github.faker.com
token: 'secret'
puppet-gitlab:
gitlab:
base_url: https://gitlab.faker.com
token: 'secret'
"""
And a file named "config_defaults.yml" with:
Expand Down Expand Up @@ -130,6 +139,7 @@ Feature: Create a pull-request/merge-request after update
puppet-test:
gitlab:
token: 'secret'
base_url: 'https://gitlab.faker.com'
"""
And a file named "config_defaults.yml" with:
"""
Expand All @@ -155,6 +165,7 @@ Feature: Create a pull-request/merge-request after update
puppet-test:
github:
token: 'secret'
base_url: 'https://gitlab.faker.com'
"""
And a file named "config_defaults.yml" with:
"""
Expand Down