pin thor to 1.3.0 #282
Merged
pin thor to 1.3.0 #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With thor 1.3.1 we've two failing tests: ``` Failing Scenarios: cucumber features/execute.feature:36 # Scenario: Show fail-fast default value in help cucumber features/execute.feature:44 # Scenario: Override fail-fast default value using config file ``` as a workaround to get CI green again we'r pinning to 1.3.0. I think the bug is fixed in rails/thor#878 but not yet released.
ekohl
reviewed
May 17, 2024
| spec.add_runtime_dependency 'octokit', '>=4', '<9' | ||
| spec.add_runtime_dependency 'puppet-blacksmith', '>= 3.0', '< 8' | ||
| spec.add_runtime_dependency 'thor' | ||
| spec.add_runtime_dependency 'thor', '1.3.0' |
There was a problem hiding this comment.
Should it have pinned to NOT 1.3.0?
There was a problem hiding this comment.
I think that's correct? 1.3.1 has a regression and rails/thor#878 contains a potential fix.
There was a problem hiding this comment.
I meant to pin to != 1.3.1. I shouldn't send comments as I'm changing trains using the mobile app. Never ends well
There was a problem hiding this comment.
ah ok. I considered that, but I don't know if the fix will be in 1.3.2 or later. So I think the safer way is pinning to 1.3.0 and dependabot will inform us for new releases.
There was a problem hiding this comment.
The reason I mention it is because dependabot also informed us about 1.3.1, but yes, this stuff is always annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With thor 1.3.1 we've two failing tests:
as a workaround to get CI green again we'r pinning to 1.3.0. I think the bug is fixed in rails/thor#878 but not yet released.