Skip to content

Conversation

kenyon
Copy link
Member

@kenyon kenyon commented Jul 23, 2025

Allowing 1.4 resolves a security issue in Thor:

We shouldn't need to support ancient Perforce facter anymore.

Allowing 1.4 resolves a security issue in Thor:

* https://github.com/voxpupuli/modulesync/security/dependabot/1
* rails/thor#897

We shouldn't need to support ancient Perforce facter anymore.
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Can you raise the same PR to openfact?

@bastelfreak bastelfreak changed the title thor: allow 1.4 thor: require 1.4 or newer Jul 23, 2025
@bastelfreak
Copy link
Member

I updated the wording in the title, ~> 1.2 already allowed 1.4.

@bastelfreak bastelfreak merged commit 8eb8a2b into voxpupuli:master Jul 23, 2025
8 checks passed
@bastelfreak
Copy link
Member

release PR: #310

@kenyon
Copy link
Member Author

kenyon commented Jul 23, 2025

I updated the wording in the title, ~> 1.2 already allowed 1.4.

Ah yeah, thanks, I misread https://guides.rubygems.org/patterns/.

kenyon added a commit to kenyon/openfact that referenced this pull request Jul 23, 2025
Thor 1.4.0 resolves a security issue: rails/thor#897

Related: voxpupuli/modulesync#309
@kenyon
Copy link
Member Author

kenyon commented Jul 23, 2025

Thanks. Can you raise the same PR to openfact?

Done: OpenVoxProject/openfact#44

kenyon added a commit to kenyon/openfact that referenced this pull request Aug 28, 2025
Thor 1.4.0 resolves a security issue: rails/thor#897

Related: voxpupuli/modulesync#309
kenyon added a commit to kenyon/openfact that referenced this pull request Aug 28, 2025
Thor 1.4.0 resolves a security issue: rails/thor#897

Related: voxpupuli/modulesync#309
kenyon added a commit to kenyon/openfact that referenced this pull request Aug 28, 2025
Thor 1.4.0 resolves a security issue: rails/thor#897

Related: voxpupuli/modulesync#309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants