-
-
Notifications
You must be signed in to change notification settings - Fork 63
add graphs for voxpupuli-test & voxpupuli-release & voxpupuli-acceptance #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Requires voxpupuli/beaker#1963 to make it more accurate |
|
Ready for review now |
_docs/how_to_run_tests.md
Outdated
| podman run -it --rm -v $PWD:/repo:Z ghcr.io/voxpupuli/voxbox:8 -f /Rakefile r10k:dependencies | ||
| ``` | ||
|
|
||
| <script src="//cdn.jsdelivr.net/npm/[email protected]/dist/mermaid.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be in the markdown file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The browser will render it to html. We do similar stuff here: https://github.com/voxpupuli/voxpupuli.github.io/blob/master/_docs/arch_load_balanced.md & https://github.com/voxpupuli/voxpupuli.github.io/blob/master/_layouts/architecture.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://blog.lindenliu.com/2020/01/07/use-mermaid-jekyll.html is very old, but the last part is a good tip that I think still works. Apply it in the layout and add use_mermaid = true in the metadata. That allows us to centralize all the mermaid inclusion to one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what use_mermaid = true is supposed to do. I can add it to the layout file, but then mermaid is added to every post.
|
Well it works but it's quite a lot to take in. Especially the second graph (voxpupuli-puppet-lint-plugins) sticks out since it fans out vertically instead of horizontally with much larger boxes and text then all the other ones |
|
Also maybe that section should be further to the end as it shadows some sections that might be more useful refrence. |
build it locally with
bundle exec jekyll serve -w --config _config.yml,_config-dev.yml