This repository was archived by the owner on Oct 26, 2022. It is now read-only.
Conversation
added 24 commits
March 7, 2020 22:05
Also, hardcode expected values instead of using helper functions strptime_utc() and unstrip(), per https://testing.googleblog.com/2014/07/testing-on-toilet-dont-put-logic-in.html (Don't Put Logic in Tests).
This is an example of a FITS image with BJD_TDB in the header. Contributed by David Valls-Gabaud.
At the same time, read_barycentric_date() becomes private. In this manner, FITSImage.date() is the single entry point, branching to either _read_uncorrected_date() (for the regular code path) or _read_barycentric_date() to read Baycentric Julian Dates. This allows us to extend the existing interface to add support for the BJD_TDB FITS keyword without having to update the rest of the pipeline.
HH MM SS.ss and DD MM SS.ss are not standard, but common enough to merit support.
Don't talk to production in tests.
added 2 commits
April 13, 2020 09:43
Travis CI clones Git submodules by default: https://docs.travis-ci.com/user/customizing-the-build#git-submodules
This fixes the "Permission denied (publickey)" error: ``` Cloning into '/home/travis/build/vterron/lemon/barycorr'... Warning: Permanently added the RSA host key for IP address '140.82.112.3' to the list of known hosts. Permission denied (publickey). fatal: Could not read from remote repository. ``` https://stackoverflow.com/q/15674064/184363
added 5 commits
April 14, 2020 19:50
Otherwise new users won't see the new features until v4 is released.
And propagate them to _read_barycentric_date().
javierblasco
approved these changes
Apr 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Barycentric Julian Dates in Barycentric Dynamical Time (
BJD_TDB). Since internally LEMON uses Unix timestamps in UTC, the values read from the FITS keyword must be first converted to JD in UTC (via Jason Eastman's server at the Ohio State University), and from there to Unix timestamps. This approach is admittedly not optimal, as we rely on the availability of the remote server for the pipeline to be able to reduce data, but it is enough for the initial prototype. Longer term we may switch to installing and usingbjd2utc.prolocally.This feature is gated via the two new flags of the
photometrycommand:--use_barycentric(to enable Barycentric Julian Dates) and--bjdk(the FITS keyword from which the BJD value is read, by default,BJD_TDB). The remaining steps of the data reduction process don't need these flags as the input of the commands (e.g.diffphot) is the output.LEMONdBfrom the previous step.Fixes #108