Skip to content

Conversation

@hiagolcm
Copy link
Contributor

What problem is this solving?

Currently, the maximum number of sponsoredProducts is hardcoded. This PR allows the developer to change it via store-theme. For example:

"store.search": {
    "blocks": ["search-result-layout"],
    "props": {
      "context": {
        "sponsoredCount": 4
      }
    }
  },

It also removes the sponsoredProductsBehavior which is a deprecated prop.

How to test it?

Workspace

Related to / Depends on

vtex-apps/search-result#691

@hiagolcm hiagolcm requested a review from a team as a code owner November 29, 2024 13:00
@hiagolcm hiagolcm requested review from RodrigoTadeuF, leo-prange-vtex and vsseixaso and removed request for a team November 29, 2024 13:00
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 29, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 29, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hiagolcm hiagolcm force-pushed the feature/sponsoredCount-prop branch from 5d5b67e to 92b613c Compare November 29, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants