Skip to content

Conversation

@edison1105
Copy link
Member

@edison1105 edison1105 commented Jul 9, 2025

@coderabbitai
Copy link

coderabbitai bot commented Jul 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/feat/useRolldown

Comment @coderabbitai help to get the list of available commands and usage tips.

@edison1105 edison1105 marked this pull request as draft July 9, 2025 08:15
@edison1105 edison1105 changed the title chore: upgrade rolldown to latest build: use rolldown Jul 9, 2025
@edison1105 edison1105 force-pushed the edison/feat/useRolldown branch from 59a42e4 to d754e71 Compare July 9, 2025 09:22
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 9, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13599

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13599

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13599

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13599

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13599

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13599

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13599

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13599

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13599

vue

npm i https://pkg.pr.new/vue@13599

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13599

commit: 42c23c7

@vuejs vuejs deleted a comment from edison1105 Dec 23, 2025
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vuejs vuejs deleted a comment from edison1105 Dec 24, 2025
@vue-bot
Copy link
Contributor

vue-bot commented Dec 24, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
router success success
primevue success success
pinia success success
radix-vue success success
quasar success success
language-tools failure failure
nuxt success success
vant success success
vite-plugin-vue success success
vueuse success success
vue-simple-compiler success success
vuetify failure failure
test-utils success success
vitepress success success
vue-i18n failure failure
vue-macros failure failure

@edison1105 edison1105 marked this pull request as ready for review December 24, 2025 08:46
Copilot AI review requested due to automatic review settings December 24, 2025 08:46
@edison1105 edison1105 merged commit 2a6ecec into rolldown Dec 24, 2025
13 checks passed
@edison1105 edison1105 deleted the edison/feat/useRolldown branch December 24, 2025 08:46
@github-project-automation github-project-automation bot moved this from Todo to Done in Next Minor Dec 24, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the build system from Rollup to Rolldown, a faster Rust-based bundler. The migration addresses several treeshaking bugs in Rolldown (as documented in the PR description) and updates all related tooling and configuration.

  • Replaces rollup with rolldown across the build system
  • Updates from @swc/core minification to oxc-minify
  • Migrates from rollup-plugin-dts to rolldown-plugin-dts for type declaration bundling
  • Updates oxc-parser and oxc-transform to v0.105.0 to match rolldown compatibility
  • Updates all build scripts, configurations, and documentation to reflect the new bundler

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsconfig.json Adds rolldown.dts.config.js to include paths
scripts/usage-size.js Migrates from rollup to rolldown, swc to oxc-minify for size analysis
scripts/inline-enums.js Updates parser API calls and type annotations for oxc-parser v0.105.0
scripts/dev.js Simplifies watch API usage with rolldown
scripts/create-rolldown-config.js Updates plugin imports, output paths, and build configuration for rolldown
scripts/build.js Updates build output path handling for rolldown
scripts/build-types.js Migrates from rollup to rolldown for type bundling
scripts/aliases.js Updates comment to reference rolldown instead of rollup
rolldown.dts.config.js Renames and updates from rollup.dts.config.js with rolldown-plugin-dts
pnpm-lock.yaml Updates all dependencies including [email protected], oxc packages, and rolldown-plugin-dts
package.json Updates build dependencies and scripts for rolldown
.github/renovate.json5 Updates dependency grouping to track rolldown and oxc packages
.github/contributing.md Updates documentation to reference rolldown instead of rollup/esbuild
packages/vue/README.md Adds rolldown to list of supported bundlers
packages/shared/src/makeMap.ts Generalizes treeshaking comment
packages/compiler-sfc/src/template/transformAssetUrl.ts Updates comment to reference @rolldown/plugin-node-polyfills
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import replace from '@rollup/plugin-replace'
import { rolldown } from 'rolldown'
import { minify } from 'oxc-minify'
import { replacePlugin } from 'rolldown/experimental'
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent import path for replacePlugin. This file imports from rolldown/experimental while scripts/create-rolldown-config.js imports from rolldown/plugins. These should use the same import path for consistency. Please verify which is the correct import path for [email protected] and update both files to use the same path.

Suggested change
import { replacePlugin } from 'rolldown/experimental'
import { replacePlugin } from 'rolldown/plugins'

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants