Skip to content

chore: remove importsNotUsedAsValues #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2024
Merged

chore: remove importsNotUsedAsValues #4897

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ad0346
chore: use `verbatimModuleSyntax` instead
KazariEX Sep 30, 2024
6d3620a
refactor: set to `true`
KazariEX Sep 30, 2024
0d06c8d
fix: vscode
KazariEX Sep 30, 2024
e524366
Revert "refactor: set to `true`"
KazariEX Sep 30, 2024
1e0a152
Revert "fix: vscode"
KazariEX Sep 30, 2024
32f41e0
Update tsconfig.base.json
johnsoncodehk Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/tsc/tests/typecheck.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ describe(`vue-tsc`, () => {
"test-workspace/tsc/failureFixtures/directives/main.vue(4,6): error TS2339: Property 'notExist' does not exist on type 'CreateComponentPublicInstanceWithMixins<ToResolvedProps<{}, {}>, { exist: typeof exist; }, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, ... 18 more ..., {}>'.",
"test-workspace/tsc/failureFixtures/directives/main.vue(9,6): error TS2339: Property 'notExist' does not exist on type 'CreateComponentPublicInstanceWithMixins<ToResolvedProps<{}, {}>, { exist: typeof exist; }, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, ... 18 more ..., {}>'.",
"test-workspace/tsc/failureFixtures/directives/main.vue(12,2): error TS2578: Unused '@ts-expect-error' directive.",
"test-workspace/tsc/passedFixtures/#3373/tsconfig.json(4,3): error TS5102: Option 'importsNotUsedAsValues' has been removed. Please remove it from your configuration.
Use 'verbatimModuleSyntax' instead.",
]
`);
});
Expand Down
4 changes: 0 additions & 4 deletions test-workspace/tsc/passedFixtures/#3373/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
{
"extends": "../../../tsconfig.base.json",
"compilerOptions": {
"importsNotUsedAsValues": "error",
"ignoreDeprecations": "5.0"
},
"include": [ "**/*" ]
}
2 changes: 1 addition & 1 deletion tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"esModuleInterop": false,
"forceConsistentCasingInFileNames": true,
"ignoreDeprecations": "5.0",
"importsNotUsedAsValues": "error",
"verbatimModuleSyntax": false,
},
"include": [ ],
}