fix(language-core): remove the non-strict configFileName default value
#5606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
rootDiris passed as/, the default value ofconfigFileNameis simply concatenated into an invalid//jsconfig.json, which causes the TSparseJsonConfigFileContentmethod to perform file searches with incorrect parameters, coincidentally making it impossible to reproduce issue #5598 in posix path systems.After this PR, I was able to reproduce #5598 on OSX.
It should be noted that for files not included in the tsconfig,
rootDirshould fall back to the workspace root directory rather than/, which requires investigation in VSCode.