Skip to content

fix(language-core): omit defined emit props only #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 11, 2025
Merged

fix(language-core): omit defined emit props only #5705

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfec3b2
wip
so1ve Oct 10, 2025
27a40d0
nice
so1ve Oct 10, 2025
ec08a5d
Fix input element formatting in child.vue
so1ve Oct 10, 2025
5d733ea
Fix formatting of input event in main.vue
so1ve Oct 10, 2025
f95fb40
Update test-workspace/tsc/passedFixtures/fallthroughAttributes/#5680/…
so1ve Oct 11, 2025
ec8fe6f
Merge branch 'master' into fix/issue-5680
so1ve Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/language-core/lib/codegen/script/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function* generatePropsOption(
if (options.templateCodegen?.inheritedAttrVars.size) {
let attrsType = `__VLS_InheritedAttrs`;
if (hasEmitsOption) {
attrsType = `Omit<${attrsType}, \`on\${string}\`>`;
attrsType = `Omit<${attrsType}, keyof __VLS_EmitProps>`;
}
getOptionCodes.push(() => {
const propsType = `__VLS_PickNotAny<${ctx.localTypes.OmitIndexSignature}<${attrsType}>, {}>`;
Expand Down
7 changes: 7 additions & 0 deletions test-workspace/tsc/passedFixtures/fallthroughAttributes/#5680/child.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<script setup lang="ts">
defineEmits<{ test: [] }>();
</script>

<template>
<input />
</template>
8 changes: 8 additions & 0 deletions test-workspace/tsc/passedFixtures/fallthroughAttributes/#5680/main.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<script setup lang="ts">
import child from "./child.vue";
import { exactType } from '../../shared';
</script>

<template>
<child @input="exactType($event, {} as Event)" />
</template>
Loading